Skip to content

Reduce wasm invocations in the stacks fuzzer#4595

Merged
alexcrichton merged 1 commit intobytecodealliance:mainfrom
alexcrichton:stacks-fuzzer-tmieout
Aug 3, 2022
Merged

Reduce wasm invocations in the stacks fuzzer#4595
alexcrichton merged 1 commit intobytecodealliance:mainfrom
alexcrichton:stacks-fuzzer-tmieout

Conversation

@alexcrichton
Copy link
Copy Markdown
Member

On oss-fuzz a test case has been found that executes 30k iterations of a
wasm trap which with a 60s timeout leaves 2ms for each invocation which
under fuzzing instrumentation is a bit of a stretch with a ~20x
slowdown. This commit places a limit on the number of inputs to the
fuzzer at 200 to keep it reasonably sized.

On oss-fuzz a test case has been found that executes 30k iterations of a
wasm trap which with a 60s timeout leaves 2ms for each invocation which
under fuzzing instrumentation is a bit of a stretch with a ~20x
slowdown. This commit places a limit on the number of inputs to the
fuzzer at 200 to keep it reasonably sized.
@alexcrichton alexcrichton requested a review from fitzgen August 3, 2022 15:35
@github-actions github-actions bot added the fuzzing Issues related to our fuzzing infrastructure label Aug 3, 2022
@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 3, 2022

Subscribe to Label Action

cc @fitzgen

Details This issue or pull request has been labeled: "fuzzing"

Thus the following users have been cc'd because of the following labels:

  • fitzgen: fuzzing

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

Copy link
Copy Markdown
Contributor

@jameysharp jameysharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always find min and max confusing when used this way, but this seems fine!

@alexcrichton alexcrichton enabled auto-merge (squash) August 3, 2022 16:01
@alexcrichton alexcrichton merged commit f587b10 into bytecodealliance:main Aug 3, 2022
@alexcrichton alexcrichton deleted the stacks-fuzzer-tmieout branch August 3, 2022 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fuzzing Issues related to our fuzzing infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants