x64: Begin migrating branch instructions to ISLE#4587
Merged
elliottt merged 6 commits intobytecodealliance:mainfrom Aug 3, 2022
Merged
x64: Begin migrating branch instructions to ISLE#4587elliottt merged 6 commits intobytecodealliance:mainfrom
elliottt merged 6 commits intobytecodealliance:mainfrom
Conversation
Subscribe to Label ActionDetailsThis issue or pull request has been labeled: "cranelift", "cranelift:area:x64", "isle"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
fitzgen
approved these changes
Aug 3, 2022
Comment on lines
+520
to
+522
| (decl single_target (MachLabel) MachLabelSlice) | ||
| (extern extractor single_target single_target) |
Member
There was a problem hiding this comment.
Could you add a little doc comment for this? Something like
;; Match a label slice of length one, extracting the only label in the slice.
Comment on lines
+523
to
+526
| (decl two_targets (MachLabel MachLabel) MachLabelSlice) | ||
| (extern extractor two_targets two_targets) |
Member
There was a problem hiding this comment.
Similar doc comment here please.
8a3679f to
c05f820
Compare
c05f820 to
97c84b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Begin migrating branch instructions for the x64 backend to ISLE.