Try using windows-latest CI#4553
Merged
alexcrichton merged 1 commit intobytecodealliance:mainfrom Jul 29, 2022
Merged
Conversation
7e9cac5 to
f1382c5
Compare
See if our `windows-2019` woes are solved now that backtraces are using frame pointers instead of native APIs.
f1382c5 to
a380f60
Compare
Member
Author
|
Ok looks like things are indeed green now! Due to our repository configuration this can't land immediately though. The CI gates we're requiring have "windows-2019" in the name whereas in this PR they switched to "windows-latest". To land this I'll need to switch the gates to the "windows-latest" version as reported in this PR. When I do that switch though all other PRs will have to rebase on this to merge since they otherwise won't have a run on "windows-latest" to succeed. |
cfallin
approved these changes
Jul 29, 2022
Member
cfallin
left a comment
There was a problem hiding this comment.
Thanks for this! Happy to finally see this perplexing bug disappear...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See if our
windows-2019woes are solved now that backtraces are usingframe pointers instead of native APIs.