Add a cranelift flag to enable/disable verbose logs for regalloc2#4481
Merged
cfallin merged 1 commit intobytecodealliance:mainfrom Jul 21, 2022
Merged
Conversation
26 tasks
Member
|
This sounds reasonable to me! |
cfallin
approved these changes
Jul 20, 2022
Subscribe to Label Actioncc @peterhuene DetailsThis issue or pull request has been labeled: "cranelift", "cranelift:area:machinst", "cranelift:meta", "wasmtime:api"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
Member
|
Apologies for the CI breakage, but things should be fixed with a rebase. |
553bb61 to
1698431
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of relying on the
log_enabledcheck to decide whether to enable regalloc2 verbose logs, I propose to use an explicit Cranelift flag to do that, as it's more explicit and allows downstream users to use thelog::trace!()level without suffering from a big performance penalty.The flag is disabled by default, because I assume this is only useful when debugging regalloc2 or understanding the decisions it took during register allocation.
As a matter of fact, in our embedding where we enable the
Tracelevel to get all logs (and filter them selectively in sometracingsubscribers), this is a 32% compile time speedup when compiling a large module in parallel on my machine.