Implement fcvt_to_sint_sat (f32x4 -> i32x4) for x86#1876
Merged
abrown merged 3 commits intobytecodealliance:masterfrom Jun 18, 2020
Merged
Implement fcvt_to_sint_sat (f32x4 -> i32x4) for x86#1876abrown merged 3 commits intobytecodealliance:masterfrom
abrown merged 3 commits intobytecodealliance:masterfrom
Conversation
Subscribe to Label Actioncc @bnjbvr DetailsThis issue or pull request has been labeled: "cranelift", "cranelift:meta", "cranelift:wasm"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
julian-seward1
approved these changes
Jun 18, 2020
Contributor
julian-seward1
left a comment
There was a problem hiding this comment.
The commit comment With user assertions, use CVTTPS2DQ directly; seems out of date (right?) -- since the idea of user assertions has been removed here. Please update before landing!
This reuses the `x86_cvtt2si` instruction since the packed and scalar versions seem to group together well.
Use a lengthy sequence involving CVTTPS2DQ to quiet NaNs and saturate overflow.
6f62360 to
85c7b33
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the same as #1820 without the runtime guarantee flags and with some extra documentation.