Duplicate page size determination in wasmtime-fiber#10803
Duplicate page size determination in wasmtime-fiber#10803alexcrichton merged 2 commits intobytecodealliance:mainfrom
wasmtime-fiber#10803Conversation
2f4bbc6 to
37e8216
Compare
Currently Wasmtime has a function `crate::runtime::vm::host_page_size` but this isn't reachable from the `wasmtime-fiber` crate and instead tha crate uses `rustix::param::page_size` to determine the host page size. It looks like this usage of `rustix` is causing a panic in bytecodealliance#10802. Ideally `wasmtime-fiber` would be able to use the same function but the crate separation does not currently make that feasible. For now duplicate the logic of `wasmtime` into `wasmtime-fiber` as it's modest enough to ensure that this does not panic. Closes bytecodealliance#10802
37e8216 to
258c0e6
Compare
wasmtime-fiber
|
I don't believe the CI failure is easily addressable with the previous design so I opted to duplicate the definition of I've also re-rolled review since Pat is on vacation right now since this has now changed substantially enough that I don't want to carry over the previous approval. |
prtest:full
|
I'm actually going to go ahead and flag this for merge. Apparently using this syscall prevents using |
Currently Wasmtime has a function
crate::runtime::vm::host_page_sizebut this isn't reachable from the
wasmtime-fibercrate and instead thacrate uses
rustix::param::page_sizeto determine the host page size.It looks like this usage of
rustixis causing a panic in #10802.Ideally
wasmtime-fiberwould be able to use the same function but thecrate separation does not currently make that feasible. For now
duplicate the logic of
wasmtimeintowasmtime-fiberas it's modestenough to ensure that this does not panic.
Closes #10802