Remove support for is_pic#10390
Merged
abrown merged 1 commit intobytecodealliance:mainfrom Mar 20, 2025
Merged
Conversation
Contributor
Author
|
Marked as draft as I would like to first see the next Cranelift version get released for #10347 to know for sure that cg_clif works with !is_pic in the jit mode. |
Contributor
Author
|
Spurious CI failure? |
Contributor
|
The CI failure originates from #10387. The tests introduced there fail only sometimes. I would love to fix the issue, but since I don’t know the cause, it would just be random shots in the dark. |
Member
|
I believe I've tracked down that sissue and @primoly I don't think the fault actually lies in your PR, it's preexisting infrastructural problems with the tests. I'll re-run the build here. |
Member
|
(specifically #10394 should solve that flaky test) |
It didn't support non-x86_64 targets anyway and adds a fair amount of complexity. There is no benefit to PIC code when jitting either.
8fe23f4 to
8bcc4f6
Compare
Contributor
Author
|
cg_clif has updated to Cranelift 0.118 and disabled is_pic usage for the JIT mode without issues. |
abrown
approved these changes
Mar 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It didn't support non-x86_64 targets anyway and adds a fair amount of complexity. There is no benefit to PIC code when jitting either.
Follow up to #10345
Closes #2735