Skip to content

Winch: Add SIMD float arithmetic support for x64 with AVX#10247

Merged
saulecabrera merged 4 commits intobytecodealliance:mainfrom
jeffcharles:winch-simd-float-arith
Feb 20, 2025
Merged

Winch: Add SIMD float arithmetic support for x64 with AVX#10247
saulecabrera merged 4 commits intobytecodealliance:mainfrom
jeffcharles:winch-simd-float-arith

Conversation

@jeffcharles
Copy link
Copy Markdown
Contributor

@jeffcharles jeffcharles commented Feb 19, 2025

Part of #8093. Adds implementations for:

  • f32x4.add
  • f64x2.add
  • f32x4.sub
  • f64x2.sub
  • f32x4.mul
  • f64x2.mul
  • f32x4.div
  • f64x2.div
  • f32x4.neg
  • f64x2.neg
  • f32x4.sqrt
  • f64x2.sqrt

@jeffcharles jeffcharles requested review from a team as code owners February 19, 2025 21:03
@jeffcharles jeffcharles requested review from alexcrichton and cfallin and removed request for a team February 19, 2025 21:03
@alexcrichton alexcrichton requested review from saulecabrera and removed request for alexcrichton February 19, 2025 22:01
@github-actions github-actions bot added the winch Winch issues or pull requests label Feb 19, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 19, 2025

Subscribe to Label Action

cc @saulecabrera

Details This issue or pull request has been labeled: "winch"

Thus the following users have been cc'd because of the following labels:

  • saulecabrera: winch

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

saulecabrera
saulecabrera approved these changes Feb 20, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@saulecabrera saulecabrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@saulecabrera saulecabrera added this pull request to the merge queue Feb 20, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 20, 2025
@saulecabrera saulecabrera added this pull request to the merge queue Feb 20, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 20, 2025
@jeffcharles
Copy link
Copy Markdown
Contributor Author

jeffcharles commented Feb 20, 2025

Going to see if merging main into this branch helps

@saulecabrera
Copy link
Copy Markdown
Member

saulecabrera commented Feb 20, 2025

I think the CI issues should be resolved once #10253 lands.

@alexcrichton alexcrichton added this pull request to the merge queue Feb 20, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Feb 20, 2025
@alexcrichton alexcrichton added this pull request to the merge queue Feb 20, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 20, 2025
@jeffcharles
Copy link
Copy Markdown
Contributor Author

jeffcharles commented Feb 20, 2025

There was a missing self.ensure_has_avx()? check in v128_neg so the Wast tests would panic instead of returning an error when the AVX extensions weren't available. I've fixed that in the latest commit.

@saulecabrera saulecabrera added this pull request to the merge queue Feb 20, 2025
Merged via the queue into bytecodealliance:main with commit acef408 Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cfallin cfallin Awaiting requested review from cfallin cfallin is a code owner automatically assigned from bytecodealliance/wasmtime-compiler-reviewers

@saulecabrera saulecabrera Awaiting requested review from saulecabrera

Assignees

No one assigned

Labels

winch Winch issues or pull requests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jeffcharles @saulecabrera