Fix parsing named locals without an inline function type #2383
+110
−65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a bug in `wast` where the generated `name` section was invalid and placed local names on the wrong location. This happened when a function type was not listed inline for a function (e.g. it was `(type $foo)`) meaning that the binary translation started with the wrong local offset. The fix here is to do a lookup of the function type to see how many parameters it has and start the indexing there, or skip emitting local names if the function type doesn't exist.
fitzgen
approved these changes
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug in
wastwhere the generatednamesection was invalid and placed local names on the wrong location. This happened when a function type was not listed inline for a function (e.g. it was(type $foo)) meaning that the binary translation started with the wrong local offset. The fix here is to do a lookup of the function type to see how many parameters it has and start the indexing there, or skip emitting local names if the function type doesn't exist.