Allow long symbol names #2340
Merged
Allow long symbol names #2340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
read symbol names in the custom linking section without the usual limits::MAX_WASM_STRING_SIZE. Internal symbols can contain the name of generated closure types and monomorphized generic arguments, leading to very long symbol names. While often not semantically meaningful to an engine, these strings are useful for debugging and not subject to any length restriction when emitted by llvm.
Contributor
Author
|
There is one more call to |
Member
|
Yeah that should be reasonable to change, basically anything in custom sections probably shouldn't be using |
alexcrichton
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read symbol names in the custom linking section without the usual
limits::MAX_WASM_STRING_SIZE.Internal symbols can contain the name of generated closure types and monomorphized generic arguments, leading to very long symbol names. While often not semantically meaningful to an engine, these strings are useful for debugging and not subject to any length restriction when emitted by llvm.
Fixes #2332