WIT: Add support for fallible constructors #2286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9479bb4 to
1450603
Compare
alexcrichton
approved these changes
Aug 21, 2025
Member
alexcrichton
left a comment
There was a problem hiding this comment.
Oh the CI failure is due to renumbering tests and shuffling things around which isn't handled well by BLESS=1 right now. To resolve that you can blow away tests/snapshots locally and then re-run with BLESS=1. Upon committing again you should see some files get deleted as they're now-stale after things were moved around internally in the test.
Otherwise though this all looks great to me, thanks! I was wondering if we want to add a separate feature gate to this but I think that's probably overkill in this case and we can just let support propagate naturally.
1450603 to
3122564
Compare
Member
Author
|
Yup, that did it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements: WebAssembly/component-model#550
Edit: What is the expected workflow regarding adding new test cases to
tests/cli/component-model/resources.wast? If I understand the CI failure correctly, I was not supposed to touch thetests/snapshots/cli/component-model/resources.wast/*.printfiles.