Share more core type infrastructure in components#1765
Merged
alexcrichton merged 1 commit intobytecodealliance:mainfrom Sep 9, 2024
Merged
Share more core type infrastructure in components#1765alexcrichton merged 1 commit intobytecodealliance:mainfrom
alexcrichton merged 1 commit intobytecodealliance:mainfrom
Conversation
This commit chiefly fixes the validator panic found in bytecodealliance#1763. This is done by sharing more infrastructure when validating types between the core module validator and the component validator. This sharing is done by extracting a new trait and moving methods from the core module to the trait and then implementing the trait for both component and core contexts. When writing tests this additionally discovered that name resolution on core types wasn't happening within components. The fix there was the same as the core module validator which was to extract shared bits to a trait and then implement the trait in both locations. Closes bytecodealliance#1763
pchickey
approved these changes
Sep 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit chiefly fixes the validator panic found in #1763. This is done by sharing more infrastructure when validating types between the core module validator and the component validator. This sharing is done by extracting a new trait and moving methods from the core module to the trait and then implementing the trait for both component and core contexts.
When writing tests this additionally discovered that name resolution on core types wasn't happening within components. The fix there was the same as the core module validator which was to extract shared bits to a trait and then implement the trait in both locations.
Closes #1763