Merge some APIs of interp and AOT modes #1509
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ule_inst Unify wasm module instance and aot module instance (bytecodealliance#1495)
…ule_inst Unify AOT/interp module inst's tables member (bytecodealliance#1503)
lum1n0us
reviewed
Sep 23, 2022
|
|
||
| bh_assert(module_inst_comm->module_type == Wasm_Module_Bytecode | ||
| || module_inst_comm->module_type == Wasm_Module_AoT); | ||
|
|
Contributor
There was a problem hiding this comment.
if WASMModuleInstance is compatible with both Wasm_Module_Bytecode and Wasm_Module_AoT, does it mean we WASMModuleInstanceCommon is not necessary?
Collaborator
Author
There was a problem hiding this comment.
Maybe, but it is used in wasm_export.h, we should carefully check whether we can remove it. My suggestion is to keep it currently, and try to remove it in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.