fast-jit call_indirect optimization #1481
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenyongh
reviewed
Sep 20, 2022
Comment on lines
387
to
390
| offset1_i32 = jit_cc_new_reg_I32(cc); | ||
| offset1 = jit_cc_new_reg_I64(cc); | ||
| GEN_INSN(SHL, offset1_i32, func_idx, NEW_CONST(I32, 2)); | ||
| GEN_INSN(I32TOI64, offset1, offset1_i32); |
Collaborator
There was a problem hiding this comment.
Should also handle the 32-bit case like above:
if (UINTPTR_MAX == UINT64_MAX) {
offset1_i32 = jit_cc_new_reg_I32(cc);
offset1 = jit_cc_new_reg_I64(cc);
GEN_INSN(SHL, offset1_i32, func_idx, NEW_CONST(I32, 2));
GEN_INSN(I32TOI64, offset1, offset1_i32);
}
else {
offset1 = jit_cc_new_reg_I32(cc);
GEN_INSN(SHL, offset1, func_idx, NEW_CONST(I32, 2));
}
Comment on lines
429
to
430
| GEN_INSN(BLTU, cc->cmp_reg, jit_basic_block_label(block_import), | ||
| jit_basic_block_label(block_nonimport)); |
Collaborator
There was a problem hiding this comment.
Should format the coding style, the CI coding guideline check reported failure.
Please install clang-format-12 to format the source file, refer to: https://github.com/bytecodealliance/wasm-micro-runtime/actions/runs/3089321530/jobs/4997498173#step:3:35
Comment on lines
452
to
455
| // if (!jit_emit_callnative(cc, jit_call_indirect, native_ret, arg_regs, 6)) { | ||
| // return false; | ||
| // } | ||
|
|
Comment on lines
475
to
487
| // import_func_ptrs_reg = get_import_func_ptrs_reg(jit_frame); | ||
| // func_import = jit_cc_new_reg_I32(cc); | ||
| // JitReg func_import_offset = jit_cc_new_reg_I32(cc); | ||
| // JitReg func_import_offset_i64 = jit_cc_new_reg_I64(cc); | ||
| // // TODO: I32/2 or I64/3, switch | ||
| // GEN_INSN(SHL, func_import_offset, func_idx, NEW_CONST(I32, 3)); | ||
| // GEN_INSN(I32TOI64, func_import_offset_i64, func_import_offset); | ||
| // GEN_INSN(LDPTR, func_import, import_func_ptrs_reg, func_import_offset_i64); | ||
| // if (!jit_emit_callnative(cc, jit_invoke_native, native_ret, arg_regs, | ||
| // 6)) { | ||
| // goto fail; | ||
| // } | ||
|
|
| GEN_INSN(LDPTR, jitted_code, fast_jit_func_ptrs_reg, jitted_code_offset); | ||
| } | ||
|
|
||
| JitReg res = 0; |
Collaborator
There was a problem hiding this comment.
Put the variable definition at the beginning of function.
| GEN_INSN(CALLBC, res, 0, jitted_code); | ||
| /* Store res into current frame, so that post_return in | ||
| block func_return can get the value */ | ||
| uint32 n = cc->jit_frame->sp - cc->jit_frame->lp; |
Author
|
fix bug in block import |
Collaborator
|
LGTM |
wenyongh
approved these changes
Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.