Refine fast jit frontend translation of op br_if and br_table #1263
Conversation
| uint32 total_size; | ||
|
|
||
| total_size = (uint32)(offsetof(JitFrame, lp) | ||
| + sizeof(*jit_frame->lp) * (max_locals + max_stacks)); |
There was a problem hiding this comment.
I don't have any opinion about the code. But just want to clarify that in a frame, all we actually care about is data in both locals and stack, right?
There was a problem hiding this comment.
No, not only locals and stacks, but also other info, e.g. frame_sp, virtual fixed registers, e.g. memory/table related registers. Since when clear_values at L972, most of the frame registers are set 0, we need to backup them firstly and then restore them after translating the dst basic block.
| total_size = | ||
| (uint32)(offsetof(JitFrame, lp) | ||
| + sizeof(*jit_frame_src->lp) * (max_locals + max_stacks)); | ||
| bh_memcpy_s(jit_frame_dst, total_size, jit_frame_src, total_size); |
There was a problem hiding this comment.
shall we consider the possibility of the overlap between jit_frame_dst and jit_frame_src?
There was a problem hiding this comment.
There should be no overlap, the memory of jit_frame_dst is allocated in jit_frame_clone, it is another memory block different from jit_frame_src.
|
LGTM |
Refine fast jit frontend translation of opcode br_if and br_table:
so as to re-use registers of current basic block
no parameters/results to copy to new block, just jumping to current
existing basic block