Reset JitCompContext #1062
Merged
Reset JitCompContext #1062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lum1n0us
commented
Mar 25, 2022
core/iwasm/fast-jit/jit_compiler.c
Outdated
| } | ||
|
|
||
| for (i = 0; i < module->function_count; i++) { | ||
| if (!jit_cc_init(cc, 64)) { |
Contributor
Author
There was a problem hiding this comment.
It is better if there is a function like jit_cc_reset() to reset block_stack, jit_frame, every JitBasicBlock.
Or else, a combination of jit_cc_destroy() and jit_cc_init() will do the work.
Contributor
Author
There was a problem hiding this comment.
my bad, jit_cc_destroy fits. No necessary to create a jit_cc_reset()
a9beda2 to
61097d8
Compare
Or else, all secondary IRs and machine code will append to the content of first function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Or else, all secondary IRs and machine code will append to the content
of first function