Focus on IF block #1049
Focus on IF block #1049
Conversation
| goto fail; | ||
| } | ||
| if (!push_jit_block_to_stack_and_pass_params( | ||
| cc, block, block->basic_block_entry, value)) |
There was a problem hiding this comment.
Should also modify L195, change if (basic_block == block->basic_block_entry) to:
if (block->wasm_code_else), if has else branch, we should generate BNE cond, basic_block_entry, basic_block_else, if no, we should generate BNE cond, basic_block_entry, basic_block_end?
There was a problem hiding this comment.
That is the part I am not sure about it yet. Let me take more time to dig into it.
Since `basic_block_else` is NULL, it meets a crash if there is a
IF block without a else branch. Like:
``` wat
(func (export "params-id") (param i32) (result i32)
(i32.const 1)
(if (param i32) (result i32) (local.get 0)
(then)
)
)
```
Consider the ELSE block will be created lazily, focus on
`basic_block_entry" here.
|
And there is another problem: after |
Yes, that's really an issue, I have tried to fix it in another PR: See load_block_results added, and the handle_op_end which calls load_block_results. Have tested some cases, but normally we should carefully check the codes and test more cases. |
Since
basic_block_elseis NULL, it meets a crash if there is aIF block without a else branch. Like:
Consider the ELSE block will be created lazily, focus on
`basic_block_entry" here.