Reset members of value_stack and allow to reuse
#1048
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After
jit_value_stack_destory(), theJitValuepointedby
value_list_headandvalue_list_endare freed andstill keep the value.
So, when
jit_value_stack_push()is called, for example,load_block_params()afterjit_value_stack_destroy()inhandle_op_else(),value_stackwill not be treated likean empty one, and new
JitValuewill be appended tovalue_list_end,which is a dangling pointer(pointer to the freed
JitValue).In my case, the crash will occur if
value_stackbe destroyedagain.
P.S.
Test with