Fix c_char vs u8 errors in the linux_raw backend.#971
Merged
sunfishcode merged 2 commits intomainfrom Dec 9, 2023
Merged
Conversation
Fix the linux_raw backend to handle the case where linux-raw-sys defines `c_char` as `i8`. linux-raw-sys used to always define `c_char` as `u8` because it usually isn't important to match the platform `char` type, but that makes it inconvenient to work with Rust's `CStr`/`CString` types which use `c_char`, so linux-raw-sys has started defining `c_char` as `i8` on platforms which define it that way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the linux_raw backend to handle the case where linux-raw-sys defines
c_charasi8.linux-raw-sys used to always define
c_charasu8because it usually isn't important to match the platformchartype, but that makes it inconvenient to work with Rust'sCStr/CStringtypes which usec_char, so linux-raw-sys has started definingc_charasi8on platforms which define it that way.