io_uring cleanups and updates for new flags in Linux 6.2#553
Merged
sunfishcode merged 1 commit intomainfrom Mar 3, 2023
Merged
io_uring cleanups and updates for new flags in Linux 6.2#553sunfishcode merged 1 commit intomainfrom
sunfishcode merged 1 commit intomainfrom
Conversation
- Rename `IoringSetupFlags`'s `SETUP_SINGLE_ISSUER` and `SETUP_DEFER_TASKRUN` to `SINGLE_ISSUER` and `DEFER_TASKRUN`, because the `SETUP_` is omitted in the other `IoringSetupFlags` flags. - Split `IoringRecvsendFlags` into `IoringSendFlags` and `IoringRecvFlags`, and add the new `ZC_REPORT_USAGE` send flag. - Add a public re-export of the new `IORING_NOTIF_USAGE_ZC_COPIED` flag. In theory we could convert `cqe.res` into a union and use a bitflags type for `IORING_NOTIF_USAGE_ZC_COPIED`, though my rough guess is that that's not worth it until it gets more complex.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename
IoringSetupFlags'sSETUP_SINGLE_ISSUERandSETUP_DEFER_TASKRUNtoSINGLE_ISSUERandDEFER_TASKRUN, because theSETUP_is omitted in the otherIoringSetupFlagsflags.Split
IoringRecvsendFlagsintoIoringSendFlagsandIoringRecvFlags, and add the newZC_REPORT_USAGEsend flag.Add a public re-export of the new
IORING_NOTIF_USAGE_ZC_COPIEDflag. In theory we could convertcqe.resinto a union and use a bitflags type forIORING_NOTIF_USAGE_ZC_COPIED, though my rough guess is that that's not worth it until it gets more complex.