This repository was archived by the owner on Mar 24, 2022. It is now read-only.
Use exact dependencies for crates within the repo#400
Merged
Conversation
Most of our thinking about semver for this project is concerned with the more "public-facing" crates like `lucetc`, `lucet-runtime`, and `lucet-wasi`, as opposed to "implementation detail" crates like `lucet-module`, `lucet-runtime-internals`, etc. As the project matures, we are paying more attention to semver for all of the crates, but this change makes the released sets of packages more consistent.
cratelyn
approved these changes
Jan 22, 2020
iximeow
approved these changes
Jan 22, 2020
Contributor
iximeow
left a comment
There was a problem hiding this comment.
Do you expect that we'll loosen these version constraints again in the future? I'm not entirely sure if we'd really want to since these more internal crates should be published alongside a repo-wide version bump and new versions of their public-intended counterparts, but I'm curious what you think.
Contributor
Author
|
I'm inclined to say no; the only reason I can think of doing so is if we decouple the versions between the crates, which we've decided not to do. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most of our thinking about semver for this project is concerned with the more "public-facing" crates like
lucetc,lucet-runtime, andlucet-wasi, as opposed to "implementation detail" crates likelucet-module,lucet-runtime-internals, etc. As the project matures, we are paying more attention to semver for all of the crates, but this change makes the released sets of packages more consistent.