This repository was archived by the owner on Mar 24, 2022. It is now read-only.
break lucetc dep in runtime-internals#393
Merged
pchickey merged 1 commit intotlc/issue-357from Jan 16, 2020
Merged
Conversation
in tests, we dont really need structured errors, so an anyhow::Error is fine.
fst-crenshaw
approved these changes
Jan 16, 2020
Contributor
fst-crenshaw
left a comment
There was a problem hiding this comment.
I expect all the tests to pass. Once they do, this has my full approval. I'm grateful for your work on eliminating this dependency!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In code review I wanted to understand exactly why lucetc was a dep of runtime-internals and by the time I used the compiler to figure it out, the fix was only two more lines.