This repository was archived by the owner on Mar 24, 2022. It is now read-only.
move lucet-module bindings tests#386
Merged
data-pup merged 2 commits intobytecodealliance:masterfrom Jan 10, 2020
Merged
Conversation
pchickey
approved these changes
Jan 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tests we currently have in
lucet-module/src/bindings.rscould be better placed in an integration test filelucet-module/tests/bindings.rs. These tests already refer to some test fixtures located in thetests/directory, so they would live closer to these fixtures if moved. These tests also don't test any private API surface, so treating them as outlined integration tests feels more honest.The only change to the tests themselves is in a separate commit, addressing a lint error about asserting on constants values. That can instead be expressed as an
assert!checking thatresult.is_err()is true.