This repository was archived by the owner on Mar 24, 2022. It is now read-only.
replace empty constructor w/ default impl#378
Merged
iximeow merged 3 commits intobytecodealliance:masterfrom Jan 21, 2020
Merged
replace empty constructor w/ default impl#378iximeow merged 3 commits intobytecodealliance:masterfrom
iximeow merged 3 commits intobytecodealliance:masterfrom
Conversation
Contributor
|
How about both? We could define one in terms of the other, too. But the standard library has so many instances of |
Member
Author
That's a good point! Will do. |
fst-crenshaw
approved these changes
Dec 13, 2019
Contributor
|
🧹 the merge-approved-but-forgotten-PRs fairy strikes 🧹 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is another "tiny lint fix I found while looking around at things" PR.
Rather than using a
CtxMap::new()constructor, we can implement theDefaulttrait, and use that instead.