This repository was archived by the owner on Mar 24, 2022. It is now read-only.
wasi_path_readlink: do not return EINVAL if an empty buffer is supplied#213
Merged
wasi_path_readlink: do not return EINVAL if an empty buffer is supplied#213
Conversation
POSIX mentions that readlink(2) and readlinkat(2) can accept an empty buffer. As usual, Linux doesn't follow the specification, and returns EINVAL if the buffer length is zero. Work around this by allocating a dummy buffer if the length is zero. Bug spotted in wasi-common, but different fix.
pchickey
approved these changes
Jun 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
POSIX mentions that
readlink(2)andreadlinkat(2)can accept an empty buffer.As usual, Linux doesn't follow the specification, and returns
EINVALif the buffer length is zero.Work around this by allocating a dummy buffer if the length is zero.
Bug originally spotted in wasi-common, but different fix.