Move plugin validation to the codegen crate #977
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Moves plugin validation from the CLI crate into the
javy-codegencrate. This results in a breaking change in thecodegencrate's API.Why am I making this change?
As part of implementing our RFC to change Javy's plugin format, I think it makes sense for the codegen crate to validate the plugin it's given so we can return a helpful error message if the plugin is invalid as opposed to having the plugin fail later with an error message that may be hard to decipher.
Checklist
javy-cli,javy-plugin, andjavy-plugin-processingdo not require updating CHANGELOG files.