[#1033] Keep cabi realloc #1035
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keep `cabi_realloc` export so it can be used with statically linked modules, refer to bytecodealliance#1033
Clarified that 'cabi_realloc' will remain in statically-linked Wasm module post generation.
Collaborator
|
Can you bump the minor version on the codegen crate to |
Contributor
Author
|
Done @jeffcharles, hope I've covered the change |
Collaborator
|
The |
Contributor
Author
|
Changed and checked that it is working fine with |
jeffcharles
approved these changes
Oct 28, 2025
Collaborator
jeffcharles
left a comment
There was a problem hiding this comment.
Looks good! Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
cabi_reallocwill now not be removed in thepostprocessstep, hence, statically-linked Wasm modules will retain it.Why am I making this change?
Memory can now be allocated using
cabi_reallocon statically-linked Wasm modules, refer to #1033Checklist
javy-cli,javy-plugin, andjavy-plugin-processingdo not require updating CHANGELOG files.For the 2nd and 3rd points in the checklist, I didn't find anything relevant to the PR but please let me know @jeffcharles if there is anything to add; I'll be happy to do so.