Remove support for compile command #1017
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saulecabrera
approved these changes
Sep 25, 2025
Member
saulecabrera
left a comment
There was a problem hiding this comment.
🎉 Looks great to me, modulo the CI failure, but I think it should be straightforward to fix.
| } | ||
|
|
||
| #[javy_cli_test(commands(not(Compile)))] | ||
| #[javy_cli_test] |
Member
There was a problem hiding this comment.
Do we need to declare root here? CI is failing with
thread 'build_test_using_invalid_plugin_with_static_build_fails' panicked at crates/cli/tests/integration_test.rs:119:5:
Expected a different string but got: terminated with status = exit status: 1, stderr = Error: No such file or directory (os error 2)
Collaborator
Author
There was a problem hiding this comment.
No, that error is the CI process couldn't find the invalid plugin I added. I probably forgot to build it in the GitHub workflow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Removes support for the
compilecommand.Why am I making this change?
The last users of the compile command are becoming unsupported so we should be able to safely remove it shortly.
Checklist
javy-cli,javy-plugin, andjavy-plugin-processingdo not require updating CHANGELOG files.