This repository was archived by the owner on Jun 26, 2020. It is now read-only.
Limit redundant jump folding to only fold parameterless target blocks#972
Merged
sstangl merged 1 commit intobytecodealliance:masterfrom Sep 5, 2019
sstangl:fold-non-phi
Merged
Limit redundant jump folding to only fold parameterless target blocks#972sstangl merged 1 commit intobytecodealliance:masterfrom sstangl:fold-non-phi
sstangl merged 1 commit intobytecodealliance:masterfrom
sstangl:fold-non-phi
Conversation
Member
|
There's no policies, so let's try to reproduce Spidermonkey's: a TODO = an issue open to discuss it and not forget about it? (There are many TODOs without matching issues at the moment, so it's fine to do best-effort here.) |
Contributor
Author
|
There's already a Bugzilla issue still open for fixing this thoroughly. That's still in my dashboard and I won't forget about it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a better solution than #950.
It's obviously possible to do better than this, for example by folding edges that cannot possible be implicit phi nodes. The purpose of this phase is mostly to undo garbage blocks created by register allocation, so this simpler version serves that goal just fine.