This repository was archived by the owner on Jun 26, 2020. It is now read-only.
Add test run to cranelift-filetests to allow executing CLIF#890
Merged
bnjbvr merged 3 commits intobytecodealliance:masterfrom Aug 21, 2019
Merged
Add test run to cranelift-filetests to allow executing CLIF#890bnjbvr merged 3 commits intobytecodealliance:masterfrom
test run to cranelift-filetests to allow executing CLIF#890bnjbvr merged 3 commits intobytecodealliance:masterfrom
Conversation
6670f39 to
1fc6ed1
Compare
e1ae5b8 to
6d543c9
Compare
Member
Author
|
Rebased; ready for review (@bnjbvr? @sunfishcode?) |
bnjbvr
approved these changes
Aug 20, 2019
Member
bnjbvr
left a comment
There was a problem hiding this comment.
Looks great to me, thanks! As suggested, maybe we could just squash the two commits together, since the second one moves code introduced in the first one? I'll make sure to merge quickly once you've addressed comments here and on the other pull request.
6d543c9 to
e926352
Compare
e926352 to
0c0c067
Compare
Member
|
There are new conflicts because of Cargo updates, can you please manually rebase @abrown ? |
This re-factors the compile/execute parts to a FunctionRunner that is shared between cranelift-filetests and clif-util. CLIF can be now be run using `clif-util run` as well as during `clif-util test` for files with a `test run` header. As before, only functions suffixed with a `run` comment are executed. The `run: fn(...) == ...` expression syntax is left for a subsequent change.
0c0c067 to
992fb31
Compare
Member
Author
|
@bnjbvr should be good to go now |
Member
|
Great work, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This depends on the change in #872; adds the ability to start running CLIF as a part of the build automation. As mentioned there, future commits will add a way (e.g.
fork) to avoid crashing the test process if a test fails and a more flexible expression syntax for asserting results (e.g.run: fn(...) == ...).