This repository was archived by the owner on Jun 26, 2020. It is now read-only.
Add temporary translation of Wasm's load_splat using Cranelift's load and splat instructions#1347
Merged
abrown merged 1 commit intobytecodealliance:masterfrom Jan 21, 2020
Merged
Conversation
…oad` and `splat` instructions If/when Cranelift gains a `load_splat` instruction, the `load + splat` could be replaced with a single Cranelift `load_splat`. This change allows the `simd_load_splat.wast` spec test to pass.
c35dff0 to
e99385b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If/when Cranelift gains a
load_splatinstruction, theload + splatcould be replaced with a single Craneliftload_splat. This change allows thesimd_load_splat.wastspec test to pass.wasmtime.