chore(rumqttc): disable default-features for tokio-rustls#941
Closed
jarhodes314 wants to merge 1 commit intobytebeamio:mainfrom
Closed
chore(rumqttc): disable default-features for tokio-rustls#941jarhodes314 wants to merge 1 commit intobytebeamio:mainfrom
jarhodes314 wants to merge 1 commit intobytebeamio:mainfrom
Conversation
11 tasks
Contributor
|
I also noticed the sudden introduction of |
Collaborator
|
@jarhodes314 check #988 , we are currently reviewing this PR. It introduces users to choose their own cryptoprovider along with default feature with aws-lc-rs |
Author
@giridher-art that looks like a suitable solution and would at least mean we can depend on the main repository and not a fork. |
Collaborator
|
@jarhodes314 if you do need any changes , please let me know ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This disables the default-features of the optional dependency
tokio-rustls. I am attempting to buildrustlswith theringbackend, rather than the newly defaultaws-lc-sysbackend. Currently the unreleased version ofrumqttcenables the default features oftokio-rustls, and this is adding an unnecessary dependency onaws-lc-sys.Type of change
Miscellaneous (related to maintenance)
Checklist:
cargo fmtCHANGELOG.mdif it's relevant to the users of the library. If it's not relevant mention why.I haven't committed any changes from
cargo fmtsince this does not affect any rust source. It did appear to make a change in one file that I haven't touched.I don't believe this needs a changelog entry as it shouldn't really affect downstream use of the crate, other than avoiding bringing in unnecessary dependencies. I believe anybody attempting to use
rustls 0.23in an application will need to callCryptoProvider::install_default, which necessitates a dependency onrustlsanyway, which allows them to select the relevant features for their use case.