rumqttc: TLS Key encoding fix#752
Merged
swanandx merged 9 commits intobytebeamio:mainfrom Nov 21, 2023
Merged
Conversation
Contributor
Author
|
Contributor
Author
|
Tested with
|
Contributor
Author
|
As discussed in #751 I have removed the |
swanandx
reviewed
Nov 16, 2023
swanandx
reviewed
Nov 16, 2023
swanandx
reviewed
Nov 16, 2023
Contributor
Author
|
Not sure why that test failed, seems unrelated? |
Contributor
Yup, it keeps failing randomly 😜 |
6 tasks
Contributor
|
Thank you for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Breaking Change
Checklist:
cargo fmtCHANGELOG.mdif it's relevant to the users of the library. If it's not relevant mention why.Description
This PR lets users of rumqttc use any of the Rustls supported key encodings [RSA (PKCS#1), PKCS#8, SEC1].
This issue addresses #751
I left the
Keyenum as is to prevent a breaking change, however it does no longer matter if the user chosesRSAorECC. For a cleaner API I think theKeyenum could be removed.