Conversation
h3nill
approved these changes
Oct 19, 2023
|
Hello, thanks for making these changes. just want to clarify. is console portion of rumqttd toml file also become optional in this upgrade ? or it will remain mandatory part. |
Contributor
Author
|
It's not done in this PR, but we do plan to make it optional. I wished some new contributor would tackle #672 . Let's wait for some time, else I will resolve it as well! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes v4 config optional so that users can specify v4 and/or v5 config ( or ws ) as per their use case.
This will allow user to use only v5 if they wish.
Type of change
Checklist:
cargo fmtCHANGELOG.mdif it's relevant to the users of the library. If it's not relevant mention why.