Skip to content

feat: non-consuming builder for Connection#708

Merged
swanandx merged 2 commits intomainfrom
connection-constructor
Sep 9, 2023
Merged

feat: non-consuming builder for Connection#708
swanandx merged 2 commits intomainfrom
connection-constructor

Conversation

@swanandx
Copy link
Contributor

@swanandx swanandx commented Sep 5, 2023

Construct Connection using builder pattern to avoid passing too many arguments to Connection::new

Type of change

  • Miscellaneous (related to maintenance)

Checklist:

  • Formatted with cargo fmt
  • Make an entry to CHANGELOG.md if it's relevant to the users of the library. If it's not relevant mention why.

Copy link

@h3nill h3nill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@swanandx swanandx merged commit 27282a8 into main Sep 9, 2023
@swanandx swanandx deleted the connection-constructor branch September 9, 2023 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants