use patched ws_stream_tungstenite to remove webpki#704
Merged
Conversation
h3nill
approved these changes
Sep 2, 2023
h3nill
left a comment
There was a problem hiding this comment.
if updating other dependencies is not requires, lets avoid that in this patch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #689 .
Once najamelan/ws_stream_tungstenite#11 is merged, and
ws_strem_tungsteniteis released with the patch, we will switch back to using it from crates.io ( most likely inws_stream_tungsteniteversion0.11.0)Until then, as this is security issue, we should not block on it and use the patched version.
Type of change
Checklist:
cargo fmtCHANGELOG.mdif it's relevant to the users of the library. If it's not relevant mention why.