Conversation
h3nill
reviewed
Sep 2, 2023
h3nill
left a comment
There was a problem hiding this comment.
apart from downside of tasks now being kept running longer as we discussed, lgtm.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bring back support for will messages and also support will delays.
We separate disconnection and publishing will messages. Will messages are published after disconnection ( and cleanup ).
Type of change
New feature (non-breaking change which adds functionality)
NOTE: This can be considered breaking as signature of some fns in rumqttd are changed. In reality, this shouldn't affect any of the user, but still.
Checklist:
cargo fmtCHANGELOG.mdif its relevant of user of the library. If its not relevant mention why.