Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to bring support for retained messages in rumqttd.
Previously, we were appending the retained messages to
datalogeverytime a subscription was made. But as every client shares same datalog, this lead to client receiving multiple messages!To fix this, we don't append messages to datalog, instead of that, we use a flag
forward_retained_messagesto indicate we still haven't forwarded the messages for a particular subscription. Once we read retained messages, we set this flag to false, which assures we only forward retained messages once!Type of change
Bug fix (non-breaking change which fixes an issue)
Checklist:
cargo fmtCHANGELOG.mdif its relevant of user of the library. If its not relevant mention why.