chore: docker image based on distroless & build and docker scripts#673
Closed
carlocorradini wants to merge 3 commits intobytebeamio:mainfrom
Closed
chore: docker image based on distroless & build and docker scripts#673carlocorradini wants to merge 3 commits intobytebeamio:mainfrom
carlocorradini wants to merge 3 commits intobytebeamio:mainfrom
Conversation
Contributor
Author
|
@de-sh Any update? 🤗🥳 |
Contributor
Author
|
i think the script is very complicated and i am not sure that its really necessary. and for distroless docker image what are the advantage to use those instead of what we have currently? |
Contributor
Author
Contributor
Author
|
These scripts are quite user-friendly (with |
Contributor
Author
|
The
Easy peasy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to PR #671
What has been changed:
rumqttdDocker image is based on distroless rather thanAlpineDocker image is now based on
gcr.io/distroless/cc(from Google) to enhance overall security since "it does not contain package managers, shells or any other programs you would expect to find in a standard Linux distribution"More robust and fully configurable scripts (see
scriptsandrumqttd/scriptsdirectories). AlsoPOSIXcompliantrumqttd/scripts/docker.shBuild and push
rumqttdDocker imagerumqttd/scripts/build.shBuild
rumqttdusingCrossNote that both scripts are configurable and also have an helper flag (
--help)