fix(Event Loop): Allow keep-alives <= 5 secs#655
Merged
h3nill merged 4 commits intobytebeamio:mainfrom Aug 20, 2023
Merged
Conversation
This PR removes the requirement that the keep alive timeout be at least 5 seconds. This is in keeping with the MQTT spec, which states that the keep alive value should be between 0 and 65535. A value of 0 indicates that no keep-alive pings are sent to the broker. Issue: bytebeamio#643 - Keep Alive has an arbitrary limit
Contributor
Author
|
Friendly ping. Is this still a viable change? |
|
Hey, sorry for the delay. we have backlog of things to review and merge but we dont have enough bandwidth. I will try to get this reviewed and merged by this month. |
|
thank you @danieldougherty! 🎉 |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the requirement that the keep alive timeout be at
least 5 seconds. This is in keeping with the MQTT spec, which
states that the keep alive value should be between 0 and 65535.
A value of 0 indicates that no keep-alive pings are sent to the
broker.
Issue: #643 - Keep Alive has an arbitrary limit
Type of change
Checklist:
cargo fmtCHANGELOG.mdif its relevant of user of the library. If its not relevant mention why.