Skip to content

Use pass#1

Merged
bysiber merged 1 commit intobysiber:fix-parser-decode-typofrom
radarhere:fix-parser-decode-typo
Feb 20, 2026
Merged

Use pass#1
bysiber merged 1 commit intobysiber:fix-parser-decode-typofrom
radarhere:fix-parser-decode-typo

Conversation

@radarhere
Copy link
Copy Markdown

@radarhere radarhere commented Feb 20, 2026

Suggestion for python-pillow#9445

The code is

if self.decoder:
  ...
elif self.image:
  ...
else:
  try:
    ...
  except OSError:
    ...
  else:
    ...
    if flag or len(im.tile) != 1:
      # custom load code, or multiple tiles
      self.decoder = None

So at the point of the change, self.decoder is already None.

@radarhere radarhere mentioned this pull request Feb 20, 2026
Merged
@hugovk
Copy link
Copy Markdown

hugovk commented Feb 20, 2026

Rather than:

if condition:
    pass
else:
    do_thing()

Invert and drop the else:

if not condition:
    do_thing()

(And rewrite the condition.)

@bysiber bysiber merged commit 0581c31 into bysiber:fix-parser-decode-typo Feb 20, 2026
@radarhere radarhere deleted the fix-parser-decode-typo branch February 20, 2026 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@radarhere @hugovk @bysiber