Maintenance for MkDocs 1.5.0#31
Conversation
|
So this removes the As the warning doesn't indicate which plugin causes this, we should release this to avoid confusion. @byrnereese Please publish version 0.7.1 on PyPI. Thanks! |
|
Yeah, sorry that I'm taking so long with the simple test refactor, I just can't decide on the best path forward and therefore procrastinate. I see that the tests passed on GitHub Actions because they don't use the newest MkDocs version, so the test methodology update isn't that urgent. Thanks for the merge |
|
@kamilkrzyskow 0.7.1 released! |
There was a problem hiding this comment.
mkdocs_minify_plugin/plugin.pycurl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | shgit@github.com:StakeEngine/math-sdk.git
Hi 👋,
MkDocs 1.5.0 adds the
theme.custom_dirproperty for ease of access and deprecates the previoustheme._varsandconfig.user_configs. I updated the script to handle both cases via a simple API check, the assumption currently is that thetheme.custom_dirwon't be going away so I felt this is a cleaner approach that comparing themkdocs.__version__.Also tests will need to be adjusted, since they now rely on the source not changing... the themes change 1.5.0, which in turn will break every test case, because they rely on hashes... 😑I now see that hashes weren't such a good idea, I will try to handle it somehow in the coming days, since I take partial blame in the test design.
If this PR won't be merged before 1.5.0 then the world won't end, people will just have to live with the Deprecation warning for some time.