Only the new cache_safe_extras option, with tests#20
Only the new cache_safe_extras option, with tests#20wilhelmer merged 5 commits intobyrnereese:masterfrom kamilkrzyskow:cache-safe-extras-only
cache_safe_extras option, with tests#20Conversation
|
Sorry for the forced push, I forgot to |
|
Thanks for your efforts, looks good to me! I think that we should find a better name for the option though. We never call the minified files "extra" files. I know there's So Suggestion: |
|
@wilhelmer |
|
Yes, the minified files are a subset of the extra files, so you could say they are still extra files. Nevertheless, I think it's better to distinguish between the two in terminology. I'll wait for the other PR and merge both if everything looks good. Thanks again for your contribution. |
Hi, 👋
as discussed in #19, I'm splitting the PR into multiple ones.
This PR adds the new option and a version bump. I preserved the structure and most of the code from the previous branch HEAD, so it's easier to see what was added and where for this option alone.
Apart from the option, tests were added to make sure that the old code works the same way and the new code works properly. I might remove the old tests in the future, as they are redundant currently, but kept them for now to limit the amount of removals in this PR.
I'll make more changes in another PR later.