#56 prototyped manual-auth-hook and different preferred-challenges support#57
Merged
byjg merged 7 commits intobyjg:masterfrom Nov 15, 2024
Merged
#56 prototyped manual-auth-hook and different preferred-challenges support#57byjg merged 7 commits intobyjg:masterfrom
preferred-challenges support#57byjg merged 7 commits intobyjg:masterfrom
Conversation
Owner
|
Hello, this change seems to be straightforward. I'll do some tests, and then approve it and merge it. Is there any specific reason to change the Dockerfile? PS: The test is failing because the docker tag is different. I have to figure out how to solve it. |
Contributor
Author
|
I changed the Dockerfile to better use layers and improve buildspeed (as I was cycling it fast as I never program in Python) |
Owner
|
I took the liberty to add the documentation and upgrade the HAPROXY version in your PR. |
byjg
approved these changes
Nov 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick implementation how it could be done to support different challenges and support
manual-auth-hook