Skip to content

use collections.abc#209

Merged
eldipa merged 1 commit intobyexamples:masterfrom
saraedum:python310
Nov 10, 2021
Merged

use collections.abc#209
eldipa merged 1 commit intobyexamples:masterfrom
saraedum:python310

Conversation

@saraedum
Copy link
Contributor

@saraedum saraedum commented Nov 9, 2021

MutableMapping has been removed from collections in Python 3.10.

(this was deprecated since Python 3.3 apparently)

MutableMapping has been removed from collections in Python 3.10.
@saraedum
Copy link
Contributor Author

saraedum commented Nov 9, 2021

We should probably also add 3.10 to the Python versions tested in test.yml. Maybe we should also bump the Python version 3.6 in test.yml since 3.6 is near end-of-life.

But these should probably go into a separate PR.

@saraedum
Copy link
Contributor Author

saraedum commented Nov 9, 2021

Not sure whether the failing tests can have anything to do with what I've been doing here.

@eldipa
Copy link
Collaborator

eldipa commented Nov 9, 2021

Yes, the tests are failing not because of the PR but because I added a test a week ago that checks the version of byexample in the documentation, but it was designed to work in the developer's environment, not in CI/github.

Also, the tests for Golang are failing. I tracked the issue to a problem in upstream (in the interpreter of go).

I will review this PR today late but I think it perfect.

Thanks for the contribution!

@eldipa
Copy link
Collaborator

eldipa commented Nov 10, 2021

I ran the tests and everything worked perfect. Merging. I will cut a new release probably at the end of the week.

Thanks a lot!

@eldipa eldipa merged commit 11de4d9 into byexamples:master Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants