Add newline check for mdox-exec output#68
Merged
bwplotka merged 2 commits intobwplotka:mainfrom Aug 4, 2021
Merged
Conversation
Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>
bwplotka
approved these changes
Aug 3, 2021
pkg/mdformatter/mdgen/mdgen.go
Outdated
| return b.Bytes(), nil | ||
| output := b.Bytes() | ||
| // Add newline to output if not present. | ||
| if !bytes.HasSuffix(output, []byte("\n")) { |
Owner
There was a problem hiding this comment.
Suggested change
| if !bytes.HasSuffix(output, []byte("\n")) { | |
| if !bytes.HasSuffix(output, newLineChar) { |
.. to not creat slice every time? (micro-optimization, but also readability) and I think we already have newLineChar somewhere 🤔
Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a check to ensure
mdgenoutput for a command always has a new line at the end so that there are no surprising formatting issues. Test case added. Fixes #67.