Merged
Conversation
Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>
bwplotka
approved these changes
Jul 30, 2021
Owner
bwplotka
left a comment
There was a problem hiding this comment.
Minor nits, only otherwise LGTM! Thanks
| if checkEmail(strings.TrimSpace(email[1])) { | ||
| return | ||
| } | ||
| v.destFutures[k].resultFn = func() error { return errors.New("email not valid " + dest) } |
Owner
There was a problem hiding this comment.
Suggested change
| v.destFutures[k].resultFn = func() error { return errors.New("email not valid " + dest) } | |
| v.destFutures[k].resultFn = func() error { return errors.Errors("provided mailto link is not a valid email, got %v", dest) } |
Comment on lines
+291
to
+295
| if strings.HasPrefix(dest, "mailto:") { | ||
| email := strings.Split(dest, "mailto:") | ||
| if checkEmail(strings.TrimSpace(email[1])) { | ||
| return | ||
| } |
Owner
There was a problem hiding this comment.
Suggested change
| if strings.HasPrefix(dest, "mailto:") { | |
| email := strings.Split(dest, "mailto:") | |
| if checkEmail(strings.TrimSpace(email[1])) { | |
| return | |
| } | |
| if email := strings.TrimPrefix(dest, "mailto:"); email != dest { | |
| if checkEmail(email) { | |
| return | |
| } |
| } | ||
|
|
||
| // checkEmail checks email structure and domain. | ||
| func checkEmail(email string) bool { |
Owner
There was a problem hiding this comment.
Suggested change
| func checkEmail(email string) bool { | |
| func isValidEmail(email string) bool { |
Check is not very verbose what exactly we are checking for
Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>
bwplotka
approved these changes
Jul 31, 2021
Owner
bwplotka
left a comment
There was a problem hiding this comment.
Sweet! and tests!! Amazing 💪🏽
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds checks for
mailto:email links like here. It validates email using regex as specified here and also checks if email has valid domain usingnet.LookupMX. Fixes #65.