Merged
Conversation
Collaborator
Author
|
For me it shows: |
bwplotka
reviewed
Jul 6, 2021
Owner
bwplotka
left a comment
There was a problem hiding this comment.
Nice, I wish all my programs has so fast execution XD
| for n := 0; n < b.N; n++ { | ||
| f := New(context.Background()) | ||
|
|
||
| b.Run(filename, func(b *testing.B) { |
Owner
There was a problem hiding this comment.
It's important to put b.N loop INSIDE the nested b.Run as this is the test case that will be benchmarked. Since you don't have we have misleading results I think.
Collaborator
Author
There was a problem hiding this comment.
Yes! Updated results:
go test -run=^$ -bench=. -benchtime 20s -memprofile mem.out -cpuprofile cpu.out -benchmem github.com/bwplotka/mdox/pkg/mdformatter/mdgen
goos: darwin
goarch: amd64
pkg: github.com/bwplotka/mdox/pkg/mdformatter/mdgen
cpu: Intel(R) Core(TM) i5-5250U CPU @ 1.60GHz
Benchmark_Mdgen_Sleep2/benchdata/sleep2.md-4 361028 65180 ns/op 42746 B/op 375 allocs/op
Benchmark_Mdgen_Sleep5/benchdata/sleep5.md-4 403152 62930 ns/op 42748 B/op 375 allocs/op
Benchmark_Mdgen_GoHelp/benchdata/gohelp.md-4 432640 57559 ns/op 42744 B/op 375 allocs/op
PASS
ok github.com/bwplotka/mdox/pkg/mdformatter/mdgen 100.219s
go test -run=^$ -bench=. -benchtime 20s -memprofile mem.out -cpuprofile cpu.out -benchmem github.com/bwplotka/mdox/pkg/mdformatter
goos: darwin
goarch: amd64
pkg: github.com/bwplotka/mdox/pkg/mdformatter
cpu: Intel(R) Core(TM) i5-5250U CPU @ 1.60GHz
Benchmark_Mdformatter/testdata/not_formatted.md-4 396523 61845 ns/op 42747 B/op 375 allocs/op
PASS
ok github.com/bwplotka/mdox/pkg/mdformatter 44.476s
go test -run=^$ -bench=. -benchtime 20s -memprofile mem.out -cpuprofile cpu.out -benchmem github.com/bwplotka/mdox/pkg/mdformatter/linktransformer
goos: darwin
goarch: amd64
pkg: github.com/bwplotka/mdox/pkg/mdformatter/linktransformer
cpu: Intel(R) Core(TM) i5-5250U CPU @ 1.60GHz
Benchmark_Linktransformer/Validator-4 250507 108464 ns/op 43955 B/op 388 allocs/op
PASS
ok github.com/bwplotka/mdox/pkg/mdformatter/linktransformer 29.197s
| f := New(context.Background()) | ||
|
|
||
| b.Run(filename, func(b *testing.B) { | ||
| buf := bytes.Buffer{} |
Owner
There was a problem hiding this comment.
Since you don't use this buf, there is a strong risk that compiler will optimize away the WHOLE thing (because result is unused).
I think it's unlikely in your case, because I don't think compiler can tell if Format has side effects or not, but it's advise to create a global testBuf variable and use that (allocate new buffer all the time)
Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>
Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>
bwplotka
reviewed
Jul 10, 2021
Owner
bwplotka
left a comment
There was a problem hiding this comment.
Looks better, did you have more meaningful results now?
Collaborator
Author
|
Yes, as mentioned here. 🙂 |
bwplotka
approved these changes
Jul 12, 2021
Owner
bwplotka
left a comment
There was a problem hiding this comment.
Amazing, let's merge but IMO we should generate bigger examples so we can see some patterns (: We can do in next PRs!
Great job LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds benchmarks for
mdformatterandmdgen.Run for mdformatter:
Run for mdgen: