Conversation
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
d75d455 to
f6f1466
Compare
4451b28 to
6660100
Compare
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
Owner
Author
|
PTAL @saswatamcode (: |
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
saswatamcode
approved these changes
May 19, 2021
Collaborator
saswatamcode
left a comment
There was a problem hiding this comment.
This looks really amazing✨! Just some suggestions.
| // the same? | ||
| func registerTransform(_ context.Context, app *extkingpin.App) { | ||
| cmd := app.Command("transform", "Transform markdown files in various ways. For example pre process markdown files to allow it for use for popular static HTML websites based on markdown source code and front matter options.") | ||
| cfg := cmd.Flag("config", "Path to the YAML file with spec defined in github.com/bwplotka/mdox/pkg/transform.Config"). |
Collaborator
There was a problem hiding this comment.
Maybe a section can be added to README about transform command, with sample config yaml, and that can be linked instead of struct? 🙂
Owner
Author
There was a problem hiding this comment.
Well, we could use mdox-exec with our tool we plan to build and do this at the point? =D Great idea!
| defer errcapture.Close(&err, file, "close file") | ||
|
|
||
| scanner := bufio.NewScanner(file) | ||
| for scanner.Scan() { |
Collaborator
There was a problem hiding this comment.
Can we check scanner.Err() after this loop?
Owner
Author
There was a problem hiding this comment.
Very good point, I missed this.
Where did you learn so many stuff about golang already??? ;p
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
Co-authored-by: Saswata Mukherjee <saswataminsta@yahoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bartlomiej Plotka bwplotka@gmail.com