Merged
Conversation
Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>
bwplotka
reviewed
Mar 29, 2021
Owner
bwplotka
left a comment
There was a problem hiding this comment.
Looks good! Can we have that tested too? 🤗
Also, I would quote all strings then! (Consistency!)
pkg/mdformatter/mdformatter.go
Outdated
| // Loop through all nested keys. | ||
| _, _ = fmt.Fprintf(b, "\n%v:", k) | ||
| for key, val := range frontMatterMap { | ||
| if v, ok := val.(string); ok && strings.Contains(v, ":") { |
Owner
There was a problem hiding this comment.
Suggestion: check if string and then always use strconv.Quote function? 🤗
Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, mdox removes all quotes from frontmatter values. But in case a value contains a semicolon, there might be yaml parsing issues in framworks like hugo. An example of this can be found here.
Before, this example would be outputted as,
This fix ensures that if a value has a semicolon, quotes would be preserved like so,